Skip to content

Commit

Permalink
c-deps: support 16K pages for ARM64
Browse files Browse the repository at this point in the history
We have had two reports of users not being able to run cockroach 23.1
on linux/arm64 with 16k pages (jemalloc does not support the page
size).  This change attempts to fix this by compiling jemalloc with
16K page support, only in the linux/arm64 configuration.

Epic: None
Informs: #106745
Release note: None
  • Loading branch information
RaduBerinde committed Jul 17, 2023
1 parent 599a374 commit 3a8a0ce
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion c-deps/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ configure_make(
"--with-lg-page=14",
],
"@io_bazel_rules_go//go/platform:linux_amd64": ["--host=x86_64-unknown-linux-gnu"],
"@io_bazel_rules_go//go/platform:linux_arm64": ["--host=aarch64-unknown-linux-gnu"],
"@io_bazel_rules_go//go/platform:linux_arm64": [
"--host=aarch64-unknown-linux-gnu",
"--with-lg-page=16",
],
"@io_bazel_rules_go//go/platform:linux_s390x": ["--host=s390x-unknown-linux-gnu"],
# NB: Normally host detection is handled by configure, but the version
# of jemalloc we have vendored is pretty ancient and can't handle some
Expand Down

0 comments on commit 3a8a0ce

Please sign in to comment.