Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: hibernate failed #31781

Closed
cockroach-teamcity opened this issue Oct 24, 2018 · 7 comments
Closed

roachtest: hibernate failed #31781

cockroach-teamcity opened this issue Oct 24, 2018 · 7 comments
Assignees
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

SHA: https://github.com/cockroachdb/cockroach/commits/5a373445c0674f060a4bfe369ad290a0cacccb6c

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stressrace TESTS=hibernate PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=982644&tab=buildLog

The test failed on master:
	test.go:644,hibernate.go:263,hibernate.go:278: 
		0 tests failed unexpectedly
		2 tests passed unexpectedly
		0 tests were not run that were expected to fail
		See artifacts/hibernate/log/logs/report for more details

@cockroach-teamcity cockroach-teamcity added this to the 2.2 milestone Oct 24, 2018
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Oct 24, 2018
@BramGruneir
Copy link
Member

This is expected thanks to fixes based on the investigation from this suite.

I'll update the test today (or tomorrow) and split the blacklist into two. One for 2.1 and one for 2.2.

@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/0dba537ae88e495ddf29b4c347b4c30ee99bd046

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stressrace TESTS=hibernate PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=983962&tab=buildLog

The test failed on release-2.1:
	asm_amd64.s:574,panic.go:502,panic.go:63,signal_unix.go:388,log.go:172,log.go:216,cluster.go:221,cluster.go:695: runtime error: invalid memory address or nil pointer dereference

@BramGruneir
Copy link
Member

This latest one is a problem with roachtest and not this specific test.

@andreimatei
Copy link
Contributor

Last crash is a random logging bug fixed in #31822. Ignore.
@bram, please yell if you see a crash in the test runner again. And sorry for the noise.

@BramGruneir
Copy link
Member

@andreimatei Will do. This time I noticed it was already being addressed so I didn't.

@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/a4950e75f6592b8cbea217cf1392d8ef8961130f

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stressrace TESTS=hibernate PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=985074&tab=buildLog

The test failed on master:
	test.go:639,test.go:651: /home/agent/work/.go/bin/roachprod create teamcity-985074-hibernate -n 1 --gce-machine-type=n1-standard-4 --gce-zones=us-central1-b,us-west1-b,europe-west2-b returned:
		stderr:
		
		stdout:
		Creating cluster teamcity-985074-hibernate with 1 nodes
		Unable to create cluster:
		in provider: gce: Command: gcloud [compute instances create --subnet default --maintenance-policy MIGRATE --scopes default,storage-rw --image ubuntu-1604-xenial-v20181004 --image-project ubuntu-os-cloud --boot-disk-size 10 --boot-disk-type pd-ssd --service-account 21965078311-compute@developer.gserviceaccount.com --local-ssd interface=SCSI --machine-type n1-standard-4 --labels lifetime=12h0m0s --metadata-from-file startup-script=/home/agent/temp/buildTmp/gce-startup-script033922571 --project cockroach-ephemeral]
		Output: ERROR: (gcloud.compute.instances.create) Could not fetch resource:
		 - Quota 'CPUS' exceeded. Limit: 1200.0 in region us-central1.
		
		: exit status 1
		Cleaning up...
		: exit status 1

BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Oct 25, 2018
This patch does two things:

- add multiple blacklists so that there can be more than one based on the
version of cockroach
- add the github issues to each test in the blacklist, so if one passes
unexpectedly we can quickly track down why

Fixes cockroachdb#31781.

Release note: None
@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/fa7fb35ebd4ed4a2a4d0c1692cb1560654b73ea6

Parameters:

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stressrace TESTS=hibernate PKG=roachtest TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=987340&tab=buildLog

The test failed on master:
	test.go:644,hibernate.go:263,hibernate.go:278: 
		0 tests failed unexpectedly
		3 tests passed unexpectedly
		0 tests were not run that were expected to fail
		See artifacts/hibernate/log/logs/report for more details

BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Oct 26, 2018
This patch does two things:

- add multiple blacklists so that there can be more than one based on the
version of cockroach
- add the github issues to each test in the blacklist, so if one passes
unexpectedly we can quickly track down why

Fixes cockroachdb#31781.

Release note: None
craig bot pushed a commit that referenced this issue Oct 26, 2018
31890: roachtest: Add github issues to blacklist r=BramGruneir a=BramGruneir

This patch does two things:

- add multiple blacklists so that there can be more than one based on the
version of cockroach
- add the github issues to each test in the blacklist, so if one passes
unexpectedly we can quickly track down why

Fixes #31781.

Release note: None

Co-authored-by: Bram Gruneir <bram@cockroachlabs.com>
@craig craig bot closed this as completed in #31890 Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Development

No branches or pull requests

3 participants