Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix a recently-introduced logging bug #31822

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

andreimatei
Copy link
Contributor

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@a-robinson a-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, was this the cause of all the nil pointer exception roachtest failures this afternoon?

@andreimatei
Copy link
Contributor Author

@a-robinson yes, very likely (if the NPE is in logging).
I've seen cause I was playing around myself, but I now see a couple of failures in my inbox too.
I'm confused about why these tests were running (presumably on TC) in the afternoon (and how come they use a roachtest binary from earlier today); in any way sorry for the trouble.

@benesch
Copy link
Contributor

benesch commented Oct 24, 2018

The roach test run takes 16h or so. It's last night's run that you're seeing.

@benesch
Copy link
Contributor

benesch commented Oct 24, 2018

Never mind. It's the "nightly" build that Alex kicked off to test rc2.

@andreimatei
Copy link
Contributor Author

andreimatei commented Oct 24, 2018 via email

craig bot pushed a commit that referenced this pull request Oct 24, 2018
31822: roachtest: fix a recently-introduced logging bug r=andreimatei a=andreimatei

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Oct 24, 2018

Build succeeded

@craig craig bot merged commit 82c9e45 into cockroachdb:master Oct 24, 2018
@andreimatei andreimatei deleted the roachtest-fix-logger branch October 25, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants