Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #248

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

rafiss
Copy link
Contributor

@rafiss rafiss commented Jul 11, 2024

This diff is from running make update-requirements.

This diff is from running `make update-requirements`.
@gordthompson
Copy link
Collaborator

gordthompson commented Jul 11, 2024

Hmm. I ran make update-requirements yesterday on 3ef9885 before responding to #247 and got slightly different results.

  1. it didn't add async-timeout, and
  2. it updated greenlet to 3.0.3 instead of removing it.
diff --git a/test-requirements.txt b/test-req-rafi.txt
index cbaa96e..c4989d3 100644
--- a/test-requirements.txt
+++ b/test-req-rafi.txt
@@ -1,13 +1,13 @@
 alembic==1.13.2
     # via -r test-requirements.in
+async-timeout==4.0.3
+    # via asyncpg
 asyncpg==0.29.0
     # via -r test-requirements.in
 attrs==23.2.0
     # via pytest
 futures==3.0.5
     # via -r test-requirements.in
-greenlet==3.0.3
-    # via sqlalchemy
 iniconfig==2.0.0
     # via pytest
 mako==1.3.5

Then, when I checked out your branch (952e409) and ran make update-requirements again, it

  1. removed async-timeout, and
  2. put greenlet 3.0.3 back in.

That seems odd, since the versions of asyncpg (0.29.0) and sqlalchemy (2.0.31) are the same. 😕

@rafiss
Copy link
Contributor Author

rafiss commented Jul 11, 2024

Interesting. I was using python 3.10.12 and pip 24.0. I wonder if that makes a difference.

@gordthompson
Copy link
Collaborator

gordthompson commented Jul 11, 2024

I'm using Python 3.12, so this

https://github.com/MagicStack/asyncpg/blob/1194a8a64484da63ecffc9b2f4ccedf5b60ee23c/pyproject.toml#L30-L32

might explain it, for asyncpg at least.

(Gotta run to a meeting. Back later.)

@gordthompson
Copy link
Collaborator

might explain it

My guess seems to be correct. Re-building my venv with Py3.9 and running make update-requirements stopped async-timeout from being removed. Hence

rafiss#1

Copy link
Collaborator

@gordthompson gordthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gordthompson gordthompson merged commit 0848b5e into cockroachdb:master Jul 17, 2024
11 checks passed
@rafiss rafiss deleted the update-requirements branch July 17, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants