Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Th/feat/use wrapper #193

Merged
merged 2 commits into from
Apr 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,25 @@ workflows:
lint-pack:
jobs:
- orb-tools/lint:
pre-steps:
- checkout
- run: git submodule init
- run: git submodule update --remote
checkout: false
filters: *filters
- orb-tools/pack:
pre-steps:
- checkout
- run: git submodule init
- run: git submodule update --remote
checkout: false
filters: *filters
- orb-tools/review:
pre-steps:
- checkout
- run: git submodule init
- run: git submodule update --remote
checkout: false
filters: *filters

# release dev version of orb, for testing & possible publishing.
Expand Down
15 changes: 10 additions & 5 deletions .circleci/test-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2.1
orbs:
codecov: codecov/codecov@dev:alpha
node: circleci/node@5
orb-tools: circleci/orb-tools@11
orb-tools: circleci/orb-tools@12
python: circleci/python@2
win: circleci/windows@4

Expand Down Expand Up @@ -165,18 +165,23 @@ workflows:
requires: [test-backend, test-frontend]

- orb-tools/pack:
pre-steps:
- checkout
- run: git submodule init
- run: git submodule update --remote
checkout: false
filters: *filters
requires: [test-linux, test-macos, test-windows]

- orb-tools/publish:
enable-pr-comment: false
enable_pr_comment: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these supposed to be underscored?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drazisil-codecov yes to all of these, it was a change from orb-tools@v11 to orb-tools@v12 docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also CircleCI-Public/orb-tools-orb#181

Parameter Standardizations
  Snake Case (to match CircleCI's native parameter styles)
  Consistent Env Var Naming

filters:
branches:
ignore: /.*/
tags:
only: /^v[0-9]+\.[0-9]+\.[0-9]+$/
orb-name: codecov/codecov
pub-type: production
orb_name: codecov/codecov
thomasrockhu-codecov marked this conversation as resolved.
Show resolved Hide resolved
pub_type: production
thomasrockhu-codecov marked this conversation as resolved.
Show resolved Hide resolved
requires:
- orb-tools/pack
vcs-type: github
vcs_type: github
thomasrockhu-codecov marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 4 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[submodule "src/scripts"]
path = src/scripts
url = https://github.com/codecov/wrapper
branch = main
1 change: 1 addition & 0 deletions src/scripts
Submodule scripts added at 9b7ac3
22 changes: 0 additions & 22 deletions src/scripts/download.sh

This file was deleted.

52 changes: 0 additions & 52 deletions src/scripts/pgp_keys.asc

This file was deleted.

66 changes: 0 additions & 66 deletions src/scripts/upload.sh

This file was deleted.

13 changes: 0 additions & 13 deletions src/scripts/validate.sh

This file was deleted.

Loading