Merge pull request #1178 from christianberkman/move-matrix

refactor: [Authorizable Trait] move $matrix outside foreach loop
codeigniter4 · Aug 23, 2024 · 304795a · 304795a
2 parents 60f1ae3 + c0268d9
commit 304795a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Authorization/Traits/Authorizable.php b/src/Authorization/Traits/Authorizable.php
@@ -250,6 +250,9 @@ public function can(string ...$permissions): bool
         // Check the groups the user belongs to
         $this->populateGroups();
 
+        // Get the group matrix
+        $matrix = setting('AuthGroups.matrix');
+
         foreach ($permissions as $permission) {
             // Permission must contain a scope and action
             if (strpos($permission, '.') === false) {
@@ -270,8 +273,6 @@ public function can(string ...$permissions): bool
                 return false;
             }
 
-            $matrix = setting('AuthGroups.matrix');
-
             foreach ($this->groupCache as $group) {
                 // Check exact match
                 if (isset($matrix[$group]) && in_array($permission, $matrix[$group], true)) {