Remove readLoop #94
Merged
Remove readLoop #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #93
Next is reusing the header structures.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 80.01% 76.27% -3.75%
==========================================
Files 14 13 -1
Lines 1001 978 -23
==========================================
- Hits 801 746 -55
- Misses 152 177 +25
- Partials 48 55 +7
Continue to review full report at Codecov.
|
Can't go any lower than this afaict. 16 bytes per Writer and 24 bytes per Reader. go tool pprof agrees with me on bytes per op but says the allocs per op are 3 instead of 4 and thinks echoLoop is allocating. I don't know. Lots of cleanup can be performed. Closes #95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93