Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove readLoop #94

Merged
merged 15 commits into from
Jun 10, 2019
Merged

Remove readLoop #94

merged 15 commits into from
Jun 10, 2019

Commits on Jun 7, 2019

  1. Remove readLoop 

    Closes #93
    @nhooyr
    nhooyr committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    f628749 View commit details
    Browse the repository at this point in the history

  2. Simplify and improve error messages

    @nhooyr
    nhooyr committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    5add79d View commit details
    Browse the repository at this point in the history

  3. Make CI pass

    @nhooyr
    nhooyr committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    5404d35 View commit details
    Browse the repository at this point in the history

  4. Reuse header and control payload buffers

    @nhooyr
    nhooyr committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    df60edf View commit details
    Browse the repository at this point in the history

  5. Reuse write and read header buffers 

    Next is reusing the header structures.
    @nhooyr
    nhooyr committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    ee1f3c6 View commit details
    Browse the repository at this point in the history

  6. Add WriteOnly example

    @nhooyr
    nhooyr committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    4357cbf View commit details
    Browse the repository at this point in the history

  7. Fix race in writeFrame

    @nhooyr
    nhooyr committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    0ed9c74 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Improve write structure

    @nhooyr
    nhooyr committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    d76d893 View commit details
    Browse the repository at this point in the history

  2. Fix docs

    @nhooyr
    nhooyr committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    4234de2 View commit details
    Browse the repository at this point in the history

  3. Fix CI

    @nhooyr
    nhooyr committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    029e412 View commit details
    Browse the repository at this point in the history

  4. Reduce allocation overhea to absolute minimum 

    Can't go any lower than this afaict. 16 bytes per Writer
and 24 bytes per Reader. go tool pprof agrees with me on
bytes per op but says the allocs per op are 3 instead of 4
and thinks echoLoop is allocating. I don't know.

Lots of cleanup can be performed.

Closes #95
    @nhooyr
    nhooyr committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    0b8b974 View commit details
    Browse the repository at this point in the history

  5. Update performance comparison

    @nhooyr
    nhooyr committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    5eff0e3 View commit details
    Browse the repository at this point in the history

  6. Fix writeOnly example

    @nhooyr
    nhooyr committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    7b05f53 View commit details
    Browse the repository at this point in the history

  7. Remove unneeded Foo test

    @nhooyr
    nhooyr committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    3e007c6 View commit details
    Browse the repository at this point in the history

  8. Fix a error resp in Accept

    @nhooyr
    nhooyr committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    73d39e2 View commit details
    Browse the repository at this point in the history