Prevent duplicated event dispatching #1381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hata6502
requested review from
gohabereg,
khaydarov and
neSpecc
as code owners
hata6502
force-pushed
the
bugfix/fix-block-selection-multiple-detection
branch
from
00874d6
to
55acc92
Compare
hata6502
commented
Oct 15, 2020
| @@ -185,7 +185,6 @@ export default class Core { | |||
| a: true, | |||
| } as SanitizerConfig; | |||
|
|
|||
|
|
|||
hata6502
commented
Oct 15, 2020
| @@ -175,7 +175,7 @@ export default class BlockSelection extends Module { | |||
| * | |||
| * Prevent such actions if focus is not inside the Editor | |||
| */ | |||
| if (!BlockManager.currentBlock) { | |||
| if (!event.target.closest(`.${this.Editor.UI.CSS.editorWrapper}`)?.isEqualNode(this.Editor.UI.nodes.wrapper)) { | |||
There was a problem hiding this comment.
When multiple Editor.js instances are launched, BlockManager.currentBlock can't be changed to null by focusing other instances.
There was a problem hiding this comment.
maybe it makes sense to create a function inside UI module that gets event and checks if event's target is under editor's instance wrapper?
There was a problem hiding this comment.
Exactly, this method seems DOM hacking!
Sorry, this problem has been resolved by #1431
hata6502
commented
Nov 23, 2020
| ) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
And... This fix is also already resolved in next.
This PR is invalid.
Sorry, I'll close it!
|
These fixes are resolved by #1431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1174