Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change shortcut listener binding #1431

Merged
merged 3 commits into from
Nov 21, 2020
Merged

Change shortcut listener binding #1431

merged 3 commits into from
Nov 21, 2020

Conversation

hata6502
Copy link
Contributor

@hata6502 hata6502 force-pushed the bugfix/change-shortcut-listener-binding branch from 0df3efb to 6d273d0 Compare November 21, 2020 07:01
@hata6502 hata6502 marked this pull request as ready for review November 21, 2020 07:01
@hata6502 hata6502 force-pushed the bugfix/change-shortcut-listener-binding branch from 6d273d0 to d056a0e Compare November 21, 2020 07:02
@khaydarov
Copy link
Member

khaydarov commented Nov 21, 2020 •
edited
Loading

We registered shortcuts on document consciously because of CMD+X according to this issue, but now we use native 'cut' event

@hata6502
Copy link
Contributor Author

@khaydarov @Thank.you for reviewing.
I'm glad to resolve the question!

@hata6502 hata6502 force-pushed the bugfix/change-shortcut-listener-binding branch from 7144bd7 to 1bc1094 Compare November 21, 2020 16:10
@hata6502 hata6502 force-pushed the bugfix/change-shortcut-listener-binding branch from 1bc1094 to 9616739 Compare November 21, 2020 17:56
@neSpecc neSpecc merged commit bbbd637 into codex-team:next Nov 21, 2020
@hata6502 hata6502 deleted the bugfix/change-shortcut-listener-binding branch November 21, 2020 18:09
@hata6502 hata6502 mentioned this pull request Nov 23, 2020
Closed
neSpecc added a commit that referenced this pull request Dec 8, 2020
@hata6502 @neSpecc
Change shortcut listener binding (#1431)
421a975 
* Change shortcut listener binding

* Update CHANGELOG.md

Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

@khaydarov khaydarov khaydarov approved these changes

@gohabereg gohabereg gohabereg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hata6502 @khaydarov @neSpecc @gohabereg