fix: inline toolbar incorrectly calculates orientation #2477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calculating the inline toolbar orientation, the selection coordinates are being adjusted for the offset of the wrapper element however, the content coordinates are not.
editor.js/src/components/modules/toolbar/inline.ts
Lines 164 to 167 in 77eb320
editor.js/src/components/modules/toolbar/inline.ts
Line 186 in 77eb320
editor.js/src/components/modules/toolbar/inline.ts
Line 199 in 77eb320
Changes
Resolves: #2476
Resolves: #2268