fix(inline-toolbar): appearance logic improved #2550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Right now we have several problems with the Inline Toolbar appearance
When editor is placed in a popup, the Inline Toolbar could move out of visible area
Sometimes position is much far from selection:
Cause
this.width
computation works incorrect sincemove()
called beforeopen()
in where tools are added.Solution
addToolsFiltered()
now called beforemove()
yarn build
command. Now we can detect build for tests and add some attributes likedata-cy
for elements querying. It's a better practice then querying by CSS class name.