Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCRE2: Explicitly specify cmake c standard #19726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryce-cahill
Copy link

@bryce-cahill bryce-cahill commented Sep 10, 2023

  • Fixes compilation issues with for loops

Specify library name and version: pcre2/10.42

Fixes #19725


@CLAassistant
Copy link

CLAassistant commented Sep 10, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Comment on lines 101 to 102
# Fix for error: 'for' loop initial declarations are only allowed in C99 or C11 mode
tc.variables["CMAKE_C_STANDARD"] = "99"
Copy link
Contributor

@SpaceIm SpaceIm Sep 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to PCRE2Project/pcre2#193:

Therefore I would recommend to patch impacted versions instead (10.40 & 10.42 I think)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, thanks for the feedback 👍

I've replaced this with a patch for the 10.42 version instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the patch so that it now cleanly applies to both 10.40 and 10.42

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Please remember to sign the CLA so that your contribution can be merged, thanks! :)

@bryce-cahill
Copy link
Author

Please remember to sign the CLA so that your contribution can be merged, thanks! :)

I've attempted to sign it twice but it appears to be stuck pending

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Feb 17, 2024
3 tasks
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (efee488343d75953260497a827c71c9dd9146bce):

  • pcre2/10.37:
    All packages built successfully! (All logs)

  • pcre2/10.40:
    All packages built successfully! (All logs)

  • pcre2/10.39:
    All packages built successfully! (All logs)

  • pcre2/10.43:
    All packages built successfully! (All logs)

  • pcre2/10.42:
    All packages built successfully! (All logs)

  • pcre2/10.36:
    All packages built successfully! (All logs)

  • pcre2/10.35:
    All packages built successfully! (All logs)

  • pcre2/10.33:
    All packages built successfully! (All logs)

  • pcre2/10.32:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (efee488343d75953260497a827c71c9dd9146bce):

  • pcre2/10.42:
    All packages built successfully! (All logs)

  • pcre2/10.43:
    All packages built successfully! (All logs)

  • pcre2/10.39:
    All packages built successfully! (All logs)

  • pcre2/10.40:
    All packages built successfully! (All logs)

  • pcre2/10.35:
    All packages built successfully! (All logs)

  • pcre2/10.37:
    All packages built successfully! (All logs)

  • pcre2/10.36:
    All packages built successfully! (All logs)

  • pcre2/10.33:
    All packages built successfully! (All logs)

  • pcre2/10.32:
    All packages built successfully! (All logs)

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 27, 2024
@AbrilRBS AbrilRBS self-assigned this Aug 27, 2024
@github-actions github-actions bot removed the stale label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] pcre2/10.42: Fails to compile - loop initial declarations are only allowed in C99 or C11 mode
6 participants