Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcre2: fix invalid pcre2-config output for static libs #20586

Merged
merged 15 commits into from
Jun 13, 2024
Merged

pcre2: fix invalid pcre2-config output for static libs #20586

merged 15 commits into from
Jun 13, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Oct 16, 2023

pcre2 includes a pcre2-config executable that outputs necessary compiler and linker flags to link against pcre2. However, it currently outputs invalid library names for static versions of the libraries.

This is a blocker for #19058, as this causes linking against pcre2 to fail.

@prince-chrismc prince-chrismc mentioned this pull request Oct 16, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Oct 16, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Oct 23, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Oct 24, 2023
Open
3 tasks
@valgur valgur force-pushed the pcre2/fix-pcre2-config branch 2 times, most recently from b6d2141 to 94bd941 Compare October 27, 2023 12:12
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Copy link
Member

I just started a new internal CI build to generate the missing pcre2/10.40.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Copy link
Member

I just launched an internal CI build to generate pcre2/10.32

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 18, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 18, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 18, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 26, 2023
Merged
@ptc-rgrasset
Copy link

Any update on this CR?

We are waiting on it for some of our dependencies.

@ghost ghost mentioned this pull request Feb 17, 2024
Merged
3 tasks
danimtb
danimtb requested changes May 28, 2024
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fix looks ok but I think there is no need to add that complexity to the test_package. Please remove the test_package changes

danimtb
danimtb reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add that complexity to test_package

recipes/pcre2/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/pcre2/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/pcre2/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/pcre2/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/pcre2/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/pcre2/all/test_package/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (e2d8c6f3267583839396380d4fa1e6f3df561474):

  • pcre2/10.43:
    All packages built successfully! (All logs)

  • pcre2/10.40:
    All packages built successfully! (All logs)

  • pcre2/10.36:
    All packages built successfully! (All logs)

  • pcre2/10.42:
    All packages built successfully! (All logs)

  • pcre2/10.33:
    All packages built successfully! (All logs)

  • pcre2/10.37:
    All packages built successfully! (All logs)

  • pcre2/10.32:
    All packages built successfully! (All logs)

  • pcre2/10.39:
    All packages built successfully! (All logs)

  • pcre2/10.35:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (e2d8c6f3267583839396380d4fa1e6f3df561474):

  • pcre2/10.43:
    All packages built successfully! (All logs)

  • pcre2/10.37:
    All packages built successfully! (All logs)

  • pcre2/10.35:
    All packages built successfully! (All logs)

  • pcre2/10.42:
    All packages built successfully! (All logs)

  • pcre2/10.39:
    All packages built successfully! (All logs)

  • pcre2/10.33:
    All packages built successfully! (All logs)

  • pcre2/10.40:
    All packages built successfully! (All logs)

  • pcre2/10.32:
    All packages built successfully! (All logs)

  • pcre2/10.36:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 8f9f1fd into conan-io:master Jun 13, 2024
53 checks passed
memsharded pushed a commit to memsharded/conan-center-index that referenced this pull request Jun 14, 2024
@valgur @danimtb @memsharded
(conan-io#20586) pcre2: fix invalid pcre2-config output for static libs
af6da8a 
* pcre2: fix invalid pcre2-config output for static libs

* pcre2: ignore noise from self.run()

* pcre2: make pcre2-config test a bit more robust

* pcre2: handle debug postfix correctly

* pcre2: no need for win_bash = True

* pcre2: drop self.tool_requires(self.tested_reference_str)

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* fix replace for 10.43

* fix fix replace

---------

Co-authored-by: Daniel <danimanzaneque@gmail.com>
conan-center-bot added a commit that referenced this pull request Jun 17, 2024
@memsharded @AbrilRBS
@Jean1995 @Jie-Cheng @valgur @uilianries @toge @robomics @MartinDelille @jcar87 @perseoGI @danimtb @czoido @uyha @conan-center-bot
(#24320) upgrading crashpad to Conan 2
5ba8f87 
* upgrading to Conan 2

* clean yaml

* removed from config.yml

* Cleanup

* use tool_requires

* wip

* (#24282) bump boost dependency

* (#23502) (#23474) simdjson/3.9.1: remove unnecessary constraints

* (#18680) kealib: migrate to Conan v2

* kealib: migrate to Conan v2

* kealib: transitive_libs=True

* kealib: simplify patch

* kealib: add v1.5.1

* kealib: bump hdf5

* kealib: add min cppstd check

* kealib: require GCC 6+

* kealib: drop v1.4.13

* kealib: bump to 1.5.2

* kealib: bump to 1.4.15

* kealib: fix MSVC lib name

* kealib: bump hdf5

* kealib: fix MSVC library names

* kealib: set HDF5_THREADSAFE based on hdf5 option

* kealib: restore GCC 5 support

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* kealib: fix a recipe bug

* kealib: add CMAKE_POLICY_DEFAULT_CMP0077

* kealib: use valid_min_cppstd()

* kealib: add cxx_std_11 to test_package

* Add missing system lib in windows

* Improve invalid config message.

---------

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* (#19228) msix: migrate to Conan v2

* msix: migrate to Conan v2

* msix: use OpenSSL v1

* msix: bump deps

* msix: fix Clang build issue

* msix: fix OpenSSL 3 support

* msix: add missing system libs

* msix: simplify xml_parser option

* msix: Clang 12 is not supported

* msix: yaml

* msix: test_package cxx_std_14

* (#24296) cpp-httplib: add version 0.16.0

* (#24297) glaze: add version 2.8.1

* (#24106) arrow: fix target names

* Use the same CMake target names as upstream

* Bugfix

* Bugfix

* Remove redundant calls to set_property("cmake_target_name")

* Revert "Remove redundant calls to set_property("cmake_target_name")"

This reverts commit fc113f0.

* Bugfix

* Bugfix

* (#24307) libftp: add version 0.5.1

* (#24298) [sentry-native] Add versions 0.7.5/0.7.6 and remove 0.7.1/0.7.2

* (#24309) glaze: add version 2.8.2

* Update PULL_REQUEST_TEMPLATE.md (#24311)

Update PR template:

- Mention list of PRs by recipe
- Simplify wording around testing locally
- request that PRs are motivated and detailed (what/why/how)

* (#24308) octo-logger-cpp: fix checksum for 1.12.0

* (#22456) proposal: update dependencies

* proposal: update dependencies

* Update recipes/proposal/all/conanfile.py

* Update recipes/proposal/all/conanfile.py

* Update recipes/proposal/all/conanfile.py

* proposal: build fewer versions

---------

Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>

* (#18949) userspace-rcu: migrate to Conan v2

* userspace-rcu: migrate to Conan v2

* userspace-rcu: add v0.14.0

* userspace-rcu: no need for a custom bootstrap script

* userspace-rcu: fix test_v1_package

* userspace-rcu: disable apple-clang for v0.11.4

* (#18986) librhash: migrate to Conan v2

* librhash: migrate to Conan v2

* librhash: use OpenSSL v1

* librhash: bump deps

* librhash: fix installation

* librhash: downgrade OpenSSL

* librhash: switch to custom CMakeLists.txt

The build scripts in the project are quite non-standard and not too portable.

Based on rhash/RHash#103

* librhash: bump openssl

* librhash: add v1.4.4

* librhash: fix the list of sources used in CMakeLists.txt

* librhash: fix missing lib prefix for libs

* librhash: don't use PROJECT_NAME

* (#18950) pbc: migrate to Conan v2

* pbc: migrate to Conan v2

* pbc: bump gmp

* pbc: use winflexbison on Windows

* pbc: add transitive_headers=True to gmp

* pbc: fix build

* pbc: fix apple cross building bug

* pbc: transitive_libs=True

* pbc: bump deps

* pbc: fix configure issue

* pbc: fix to_apple_arch()

* pbc: add MSVC support

* pbc: add AutotoolsDeps workaround for MSVC

* pbc: add MSVC ./configure workarounds

* pbc: not compatible with MSVC due to use of GNU extensions

* pbc: fix_apple_shared_install_name()

* (#18948) hiredis/0.x.x: remove 0.x recipe

* hiredis/0.x.x: migrate to Conan v2

* hiredis/0.x.x: fix_apple_shared_install_name(self)

* Dropped support for very old 0.x.x versions

---------

Co-authored-by: PerseoGI <perseog@jfrog.com>

* (#23997) mini: add recipe

* mini: add recipe

* Update recipes/mini/all/test_package/test_package.cpp

---------

Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>

* (#24300) octo-logger-cpp: bumped fmt dependency

* (#20586) pcre2: fix invalid pcre2-config output for static libs

* pcre2: fix invalid pcre2-config output for static libs

* pcre2: ignore noise from self.run()

* pcre2: make pcre2-config test a bit more robust

* pcre2: handle debug postfix correctly

* pcre2: no need for win_bash = True

* pcre2: drop self.tool_requires(self.tested_reference_str)

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* Update recipes/pcre2/all/test_package/conanfile.py

* fix replace for 10.43

* fix fix replace

---------

Co-authored-by: Daniel <danimanzaneque@gmail.com>

* (#19239) pro-mdnsd: migrate to Conan v2

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* (#24262) reflect-cpp: add option for using with msgpack

* reflect-cpp: add option for using with msgpack

* reflect-cpp: fix with_msgpack option

---------

Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>

* (#24011) arrow: add version 16.1.0

* arrow: add version 16.1.0

* Format build method

---------

Co-authored-by: PerseoGI <perseog@jfrog.com>

* (#24312) [bot] Update authorized users list (2024-06-13)

Co-authored-by: conan-center-bot <luism+c3ibot@jfrog.com>

* (#24273) [boost] Add -fcoroutines for GCC10 only

* Add -fcoroutines for GCC10 only

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Use b2 ranged version

Signed-off-by: Uilian Ries <uilianries@gmail.com>

---------

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* (#24318) glaze: add version 2.8.4

* (#24316) jsoncons: add version 0.176.0

* (#24306) libmaxminddb: add version 1.10.0

* libmaxmind: add version 1.10.0

* add with_binaries option

* Cleanups

* append PATH on with_binaries=True

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* (#24323) pcre2: add version 10.44

* test pr do not merge

* Revert "test pr do not merge"

This reverts commit f146b96.

* (#24328) change gn validate to validate_build

* package license

* update to set_property for cmake_build_modules

* add library type

---------

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Jean-Marco Alameddine <jean-marco.alameddine@udo.edu>
Co-authored-by: Jie Cheng <chengjiehust@gmail.com>
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: toge <toge.mail@gmail.com>
Co-authored-by: Roberto Rossini <71787608+robomics@users.noreply.github.com>
Co-authored-by: Martin Delille <martin@delille.org>
Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Co-authored-by: PerseoGI <perseog@jfrog.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Beartama <8091245+uyha@users.noreply.github.com>
Co-authored-by: Conan Center Index Bot <54393557+conan-center-bot@users.noreply.github.com>
Co-authored-by: conan-center-bot <luism+c3ibot@jfrog.com>
@valgur valgur mentioned this pull request Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@jwillikers jwillikers jwillikers approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@valgur @conan-center-bot @uilianries @ptc-rgrasset @danimtb @jwillikers