boost: remove b2-default value of layout option
#20336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logic of this value in configure() can't work in conan v2, it raises a ConanException. If folks want default layout for Windows, they can set layout to versioned instead of this removed b2-layout.
|
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers you might be interested. 😉 |
This was referenced Oct 3, 2023
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 1c83094boost/1.83.0@#082c96117dbdc7dc78f45b601268d362boost/1.82.0@#3347635f6da76465b8d39c7488155bceboost/1.81.0@#ab9dabb21c28432bc1092ff1bc6564a3boost/1.77.0@#11e87e9713334fa1c71a880a92937321boost/1.78.0@#d5d46c13120b0855257347f7e4aad0fcboost/1.73.0@#c02bfd577bd6ffdc57ac1fb494c7979eboost/1.80.0@#1e94d944acfd3cf5e6502897e95cff72boost/1.79.0@#e3ec245bc13e2959c921a8302b7e2f34boost/1.74.0@#9465cd6359a614fcd019431ecd662b4bboost/1.71.0@#533591956da0d6942b73824ac6897bdcboost/1.76.0@#ecbc80552085153998b139d6df689d42boost/1.72.0@#f5e7adccb9f001fbf3ac9b440eb5532eboost/1.75.0@#281c8db52d169067eb9fa114896b5270 |
|
See also conan-io/conan#14868 for explanations |
AbrilRBS
requested changes
Oct 6, 2023
|
I don't understand. As explained, this value was a mistake from the beginning, just an ugly way to provide default layout irrespective of host machine. If we really want the correct default layout, we should do conditional in config_options for layout option depending on os. But it may break many pre-build shared packages of downstream recipes for Windows. So I've kept default value of layout option, and anyway consumers can change layout to versioned if they want... Therefore this b2-default was useless. I've linked conan-io/conan#14868 because custom logic of boost recipe regarding b2-default was somewhat similar, but the main problem of conan-io/conan#14868 is related to deprecated options actually, and this b2-default was not a deprecation mechanism. |
jwillikers
approved these changes
Oct 16, 2023
|
@RubenRBS can you unblock? from my point of view, |
This was referenced Dec 11, 2023
ghost
mentioned this pull request
3 tasks
This was referenced Jan 19, 2024
This was referenced Jan 31, 2024
ghost
mentioned this pull request
3 tasks
valgur
approved these changes
Feb 28, 2024
ghost
mentioned this pull request
3 tasks
ghost
mentioned this pull request
3 tasks
uilianries
reviewed
Jul 24, 2024
There was a problem hiding this comment.
It looks good, considering:
The b2-default is a virtual auto value for Boost project, the same does not exist in Boost project, only system, versioned and tagged are available: https://github.com/boostorg/boost/blob/e4b2e2d6a11c9596a022ddfaa49c7a3c6261e297/boostcpp.jam#L64
It's true in Windows, Boost uses versioned by default, but in this recipe we have been enforced the system by default to any platform.
Plus, I'm not confident in auto values, as the upstream may change in future and we miss it when reviewing.
I just talked to @AbrilRBS first, so I'll wait her thoughts first.
AbrilRBS
approved these changes
Jul 30, 2024
uilianries
approved these changes
Jul 31, 2024
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
Hooks produced the following warnings for commit 1c83094boost/1.83.0@#f8c3d7363db580d9c19a9cfe8dc72691boost/1.79.0@#5c44343f74b3b5956f807ae62e47c321boost/1.85.0@#0146e46a0e32fbb44e7189f25c193daeboost/1.74.0@#a8c6bb7cfaa5bc06be5d25798c225cf2boost/1.84.0@#0782f5013c2e065b1a69f2a0397ae9b7boost/1.75.0@#ab276f7d6b38f8bbc6b2e6355407c754boost/1.73.0@#2c9fe41f6f6e7de7c863b47ebca19045boost/1.81.0@#929f1e244f121f10d11a82009c466cd3boost/1.78.0@#8ebf75b5c55dc6000202a1b1f0eb5992boost/1.82.0@#20a883942beee1ebdda43efb5a49b0a1boost/1.72.0@#dc2b851dcdc6ff5ba6546154a62513a9boost/1.71.0@#cd795842a22331fb9eb4093a12cf4f8cboost/1.80.0@#98c121475a82553038f2ad8c9623e47cboost/1.77.0@#8ac7825236e6f9f156175d9241f6dfbcboost/1.76.0@#3363ee59fe1aed3374493cac0501d61d |
uilianries
pushed a commit
to uilianries/conan-center-index
that referenced
this pull request
Aug 7, 2024
logic of this value in configure() can't work in conan v2, it raises a ConanException. If folks want default layout for Windows, they can set layout to versioned instead of this removed b2-layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logic of this value in configure() can't work in conan v2, it raises a ConanException (see https://cpplang.slack.com/archives/C41CWV9HA/p1696374024080289)
If folks want default layout for Windows, they can set layout to versioned instead of this removed b2-layout, so this value was more or less useless.