-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: Honoring tools.build:defines #22679
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit dec149bboost/1.84.0@#6800adefa052c9bd2236b6629b3980e2
boost/1.83.0@#2cac22c63c63f8f7fd812bbd805fcb43
boost/1.82.0@#63bba4c219a6361b5b9646ae388d165c
boost/1.78.0@#93924c19a3ba08ea968e357a80299f60
boost/1.81.0@#04274e565566fadc6c2e2890b8f5576a
boost/1.77.0@#40b82e8cfc00b6bb5be96a84dbb0bfa4
boost/1.71.0@#319ae8144c8db8d9cd5b094085aeedd0
boost/1.72.0@#8c94dd2fb7f271ce6c200bdc267623a7
boost/1.79.0@#5766459cb22708c882cce7fb32d87dd0
boost/1.74.0@#73ce1d4b63c65b592a625a6c62b1d29f
boost/1.76.0@#fa9cd23bbcbd6071266a85fbbcabb0bd
boost/1.80.0@#563039e94e9f72d43bf907043713cdc7
boost/1.75.0@#7d354ec9b93eca4208c33fbc458dbe49
boost/1.73.0@#3d7c605e03eb82f34be9eb4c33a1e361
|
This comment has been minimized.
This comment has been minimized.
dec149b
to
26df461
Compare
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
Hooks produced the following warnings for commit 26df461boost/1.84.0@#5cc9767cd47ba6b5e1b53ab4670f07fc
boost/1.83.0@#20336b52d154a33834c8087c4dffed8f
boost/1.79.0@#b4e597eae8176d57f72f7d74839378a1
boost/1.82.0@#e88a9ace0233606c823852c43ebb4fcd
boost/1.81.0@#81c9856a766db667128e9808f6bdc919
boost/1.80.0@#61756fb46ca711fbc9bcee51ee4023f7
boost/1.73.0@#b3d01a16083f1363076fe2504497b734
boost/1.78.0@#60180b92eef87edfaed4e222d585db24
boost/1.77.0@#7de36cd68cc9c2aaff0d3a03db3d8a2c
boost/1.76.0@#30a2733968ffe72f2bd9ec139b6f6a6e
boost/1.74.0@#b2dca0d6e94f2425f5db0bfbad7535b4
boost/1.71.0@#df265749fd0e213b85ded095dd194f5a
boost/1.72.0@#b7c45e19ad06040710c0dcd5462c7b16
boost/1.75.0@#cdd7de4264efd4a177d741f5ea0b8e7b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
boost/*
According to the docs build_and_package recipes should honor the configuration
tools.build:defines
I have thus added defines to cflags and cxxflags in the recipe!
closes #22619