Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix itk/5.1.2 with cpp20 #22235

Closed
wants to merge 1 commit into from

Conversation

fdgStilla
Copy link
Contributor

Fix #19418


Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdgStilla Thank you for your backport, but I see ITK offers new releases (RC) with these patches incorporated already.

I would ask to not try backporting it, but add a new version instead. So, who needs to use >=C++17 should include an official version already patched to support C++20.

https://github.com/InsightSoftwareConsortium/ITK/tags

https://github.com/InsightSoftwareConsortium/ITK/blob/v5.4rc02/Modules/Core/Common/include/itkThreadPool.h

@fdgStilla
Copy link
Contributor Author

Can we add release candidate to conan?

@uilianries
Copy link
Member

Can we add release candidate to conan?

Yes. It's not encouraged because we will have a temporary release which will be available for few time and occupy not only Conan Ceneter, but require CI resource to be built. Same for alpha and beta versions.

However, some projects delay many months between each release, so providing RC is fine. We just don't recommend bumping version for each RC in case they are not really used by users.

@AbrilRBS
Copy link
Member

Closing in favour of adding the recently released 5.4 version, will do so in the following days. Thanks a lot for your patience in this one :)

@AbrilRBS AbrilRBS closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] itk/5.1.2: configuration fails with C++20 or higher
3 participants