Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msdfgen: refactor test package #24134

Merged

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented May 28, 2024

Simplify the test_package in according to our policies:

  • Write the minimal test that tests the package (the compiler can find the correct includes, the static linker can resolve
    symbols, the runtime linker can resolve symbols).
  • Do not perform heavy logic in CI.
  • Remove binary blob - these have not been allowed anywhere in the repository for a while now, it's time to drop them where they exist

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request May 28, 2024
3 tasks
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (d749b4ad6283856e8a9888f7e1153031966e11ec):

  • msdfgen/1.11:
    All packages built successfully! (All logs)

  • msdfgen/1.9.1:
    All packages built successfully! (All logs)

  • msdfgen/1.9:
    All packages built successfully! (All logs)

  • msdfgen/1.10:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (d749b4ad6283856e8a9888f7e1153031966e11ec):

  • msdfgen/1.11:
    All packages built successfully! (All logs)

  • msdfgen/1.10:
    All packages built successfully! (All logs)

  • msdfgen/1.9.1:
    All packages built successfully! (All logs)

  • msdfgen/1.9:
    All packages built successfully! (All logs)

@uilianries uilianries requested a review from AbrilRBS May 28, 2024 14:59
@AbrilRBS AbrilRBS self-assigned this May 28, 2024
@conan-center-bot conan-center-bot merged commit d6319bd into conan-io:master May 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants