Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow uploading on main channel #337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Aug 19, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

now that we have implemented all rattler-build lints checks and we have a working feedstock: https://github.com/conda-forge/jolt-physics-feedstock
I would like to uplift restrictions of uploading rattler-build to main channel.

Should be merged after release of: conda-forge/conda-smithy#2037

@nichmor nichmor requested a review from a team as a code owner August 19, 2024 09:25
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wait a bit imho for the dust to settle on the linter. There are a few PRs left. Also the bot is not yet finished, which might break things.

@nichmor
Copy link
Contributor Author

nichmor commented Aug 19, 2024

We need to wait a bit imho for the dust to settle on the linter. There are a few PRs left. Also the bot is not yet finished, which might break things.

Hey ! Thanks for the review!

Can we make an actionable plan for linter work?
I know that there is conda-forge/conda-smithy#2028 work that needs to be done.
Do you have anything else on your radar?

Regarding the bot work- can it block us from allowing us to upload on the main channel? I think that even we break things we do it on bot side, uploaded packages are not affected? Do you have something on your mind how we can achieve this?

@beckermr
Copy link
Member

It depends on how the bot breaks. If people convert feedstocks that need ABI migrations or version migrations, we'll break more than just a single feedstock. Things that affect the whole ecosystem like this have to move slowly enough for folks to adapt.

@baszalmstra
Copy link
Member

baszalmstra commented Aug 20, 2024

@beckermr I completely understand where you are coming from but I feel the issue of packages not being uploaded is a bit of a chicken-and-egg problem. We have already had people (in the chat) wanting to convert their feedstock but holding off because the packages would not get uploaded. That makes it hard for the dust to settle. I know @jaimergp also had different ideas about this.

From my perspective, these are the issues that are left open:

conda-smithy:

bot:

Am I missing issues or pull-requests?

@beckermr
Copy link
Member

The ABI migrations run mini migrators on top of the recipes. We'll need to merge the prs to skip those or make them work on the new format.

@baszalmstra
Copy link
Member

The ABI migrations run mini migrators on top of the recipes. We'll need to merge the prs to skip those or make them work on the new format.

Is there already an issue for this so we can keep track of it?

@beckermr
Copy link
Member

beckermr commented Aug 20, 2024

On the bot repo it is issues 2918 2920 and 2924

@baszalmstra
Copy link
Member

Thanks I updated the overview. 👍

@beckermr
Copy link
Member

Another issue is that the solver checks repo does not currently work for v1 recipes: regro/conda-forge-feedstock-check-solvable#54

Do we have a tracking issue on the website repo for this? If not we should.

@wolfv
Copy link
Member

wolfv commented Sep 10, 2024

Some smaller progress was made wrt to the CODEOWNERS file - a change in rattler-build-conda-compat should have made it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants