fix: pass --extra-meta for rattler-build #2037
Conversation
|
There is a |
|
should also fix: conda-forge/crane-feedstock#6 |
|
@wolfv Can you verify that |
|
I did just double check, and rattler-build unconditionally skips test execution which is what conda-build also does. |
| if [[ "${HOST_PLATFORM}" != "${BUILD_PLATFORM}" ]] && [[ "${BUILD_WITH_CONDA_DEBUG:-0}" != 1 ]]; then | ||
| EXTRA_CB_OPTIONS="${EXTRA_CB_OPTIONS:-} --no-test" | ||
| fi | ||
| {%- elif test == "native_and_emulated" -%} | ||
| {%- elif test == "native_and_emulated" and conda_build_tool != "rattler-build" -%} |
There was a problem hiding this comment.
is this correct? If we need --no-test then this is going to be missing in the rattler-build case, right?
There was a problem hiding this comment.
Initially it was disabled by me, but now that --no-test is working for rattler-build I need to remove this check
|
Do we need to set the rattler-build version somewhere to Looks good to me! |
I think the minimal should be but we can merge this anyway,no? |
|
Yep! |
|
Please do not merge if I have requested changes. Thanks. |
Checklist
newsentrypython conda_smithy/schema.py)Closes #2034
Actual run can be seen here: conda-forge/jolt-physics-feedstock#2