-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix frozendict
usage
#5345
Fix frozendict
usage
#5345
Conversation
Review build status
Once it's done, use this command to try it out in a new conda environment:
|
CodSpeed Performance ReportMerging #5345 will not alter performanceComparing Summary
|
@jakirkham can you review this PR/test the canary build and confirm this fixes the |
6415670
to
8a74709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham will you be able to review/test this? we'd like to get a patch release ready to go for next week |
@deprecated( | ||
"24.5.1", | ||
"24.7.0", | ||
addendum="Use `conda_build.metadata._check_circular_dependencies` instead.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underscored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #5345 (comment)
@@ -907,6 +953,59 @@ def toposort(output_metadata_map): | |||
return result | |||
|
|||
|
|||
def _toposort_outputs(output_tuples: list[OutputTuple]) -> list[OutputTuple]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this code mostly copied from elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a copy of the now deprecated toposort
function in the same module, we added these new functions since the function signatures themselves changes, see #5345 (comment)
Thanks all! 🙏 The fix worked great 😄 |
Description
A very specific use case results in the code trying to modify a
frozendict
version of the output dict.Fix #5342
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update outdated documentation?