Fix excessive memory use in inspect_linkages_lief
#5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduced in condagh-5228 which replaced binary.name with str(file). The former returns the path to the binary whereas the latter returns the contents of the parsed binary, naturally causing high memory usage. That semantic change was unintended (misread upstream changes). Since binary's path is no longer part of the object, pass it separately. Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
to avoid variable shadowing. Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
conda-bot
added
the
cla-signed
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
CodSpeed Performance ReportMerging #5348 will not alter performanceComparing Summary
|
kenodegard
approved these changes
May 21, 2024
I'm currently out of office but if @jezdez is also on board, I can work on a patch release starting on Wednesday May 21st, especially if #5345 looks good to go and can also be included (otherwise I can do a separate patch release to include that change) |
beeankha
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
introduced in gh-5228 which replaced
binary.namewithstr(file).The former returns the path to the binary whereas the latter returns the
contents of the parsed binary, naturally causing high memory usage.
That semantic change was unintended (misread upstream changes).
Since binary's path is no longer part of the object, pass it separately.
Fixes gh-5267
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?