Merge pull request #38 from confio/34-valset-better-error-message-whe…

…n-jail-lock-not-expired Valset: better unjail error message when jail lock didn't expire
confio · Jan 25, 2022 · 7591d6d · 7591d6d
2 parents 433b1cd + 845ecbc
commit 7591d6d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/contracts/tgrade-valset/src/contract.rs b/contracts/tgrade-valset/src/contract.rs
@@ -272,8 +272,8 @@ fn execute_unjail(
         Ok(Some(expiration)) if (expiration.is_expired(&env.block) || is_admin) => {
             JAIL.remove(deps.storage, operator);
         }
-        // Jail not expired and called by non-admin
-        _ => return Err(AdminError::NotAdmin {}.into()),
+        // Jail not expired
+        _ => return Err(ContractError::JailDidNotExpire {}),
     }
 
     let res = Response::new()

diff --git a/contracts/tgrade-valset/src/error.rs b/contracts/tgrade-valset/src/error.rs
@@ -68,6 +68,9 @@ pub enum ContractError {
 
     #[error("Cannot unjail validator who's been jailed forever")]
     UnjailFromJailForeverForbidden {},
+
+    #[error("Jail did not yet expire")]
+    JailDidNotExpire {},
 }
 
 impl From<Ed25519PubkeyConversionError> for ContractError {

diff --git a/contracts/tgrade-valset/src/multitest/jailing.rs b/contracts/tgrade-valset/src/multitest/jailing.rs
@@ -138,17 +138,11 @@ fn anyone_can_unjail_self_after_period() {
 
     // I cannot unjail myself before expiration...
     let err = suite.unjail(members[0], None).unwrap_err();
-    assert_eq!(
-        ContractError::AdminError(AdminError::NotAdmin {}),
-        err.downcast().unwrap(),
-    );
+    assert_eq!(ContractError::JailDidNotExpire {}, err.downcast().unwrap(),);
 
     // ...even directly pointing myself
     let err = suite.unjail(members[0], members[0]).unwrap_err();
-    assert_eq!(
-        ContractError::AdminError(AdminError::NotAdmin {}),
-        err.downcast().unwrap(),
-    );
+    assert_eq!(ContractError::JailDidNotExpire {}, err.downcast().unwrap(),);
 
     // And I cannot unjail anyone else
     let err = suite.unjail(members[0], members[1]).unwrap_err();