Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valset: better unjail error message when jail lock didn't expire #38

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Valset: better unjail error message when jail lock didn't expire #38

merged 1 commit into from
Jan 25, 2022

Conversation

ueco-jb
Copy link

@ueco-jb ueco-jb commented Jan 25, 2022 •
edited
Loading

closes #34

@ueco-jb ueco-jb self-assigned this Jan 25, 2022
uint
uint approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueco-jb ueco-jb merged commit 7591d6d into main Jan 25, 2022
@ueco-jb ueco-jb deleted the 34-valset-better-error-message-when-jail-lock-not-expired branch January 25, 2022 15:31
@ethanfrey
Copy link
Contributor

We should back port this to the 0.5.x branch.

Maybe best if we squash PRs that will be back ported, so git cherry-pick becomes easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uint uint uint approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

@hashedone hashedone Awaiting requested review from hashedone

@maurolacy maurolacy Awaiting requested review from maurolacy

Assignees

@ueco-jb ueco-jb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

valset: better error message when jail lock not expired
3 participants
@ueco-jb @ethanfrey @uint