Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valset tie-breaking #3 #118

Merged
merged 26 commits into from
Apr 1, 2022
Merged

Valset tie-breaking #3 #118

merged 26 commits into from
Apr 1, 2022

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Feb 25, 2022 •
edited
Loading

Third attempt at closing #22. Follows the plan outlined in #22 (comment).

TODO:

  • Removing (or not) the optional start_height from MemberResponse, for simplicity. (not removing)

@maurolacy maurolacy added breaking-state Storage breaking: Requires migration breaking-api API breaking: Remove, Change (rename, change type), Add non-optional / non-default field breaking Breaking changes (API or State) labels Feb 25, 2022
@maurolacy maurolacy force-pushed the 22-valset-tie-breaking-3 branch 2 times, most recently from ca15a72 to d595aba Compare February 25, 2022 15:30
@maurolacy maurolacy mentioned this pull request Mar 9, 2022
Closed
Mauro Lacy added 20 commits March 30, 2022 09:30
Add MemberInfo to tg4
99f1fe4
Store members points / start heights using MemberInfo
f4e6ead
Adapt raw tg4 member query to new format
4e78730
tg4-engagement: Adapt to new members value format
96d0d43
tg4-stake: Adapt to new members value format
22854c3
Redefine members() IndexedMap
cca7d41 
Add extra points index for tie breaking by start height
Add MemberInfo::new_with_points constructor
5f61f0f
tg4-mixer: Adapt to custom members()
78376a9 
Add start_height info to `MemberInfo`
Add optional start_height to Member and MemberResponse
608b829
tg4-engagement: Adapt to new Member / MemberResponse value format
2bb03dc
voting-contract: Adapt to new Member value format
313f0ee
tg4-group: Adapt to new Member value format
3bbcb5b
tg4-stake: Adapt to new Member value format
3c3c9f8
tg4-mixer: Use tie-breaking index
d756457
tg4-mixer: Remove unused points index
26cab6b
tg4-valset: Adapt to new Member format
63e8672
Adapt voting-contract tests to new Member format
5bd7f48
Adapt contracts tests to new Member format
229f742
Add members by points tie-breaking tests
f3f8acb
Fix: default start_height
b74060e 
When adding member to tg4-mixer first time
hashedone
hashedone approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maurolacy maurolacy merged commit 1d3d49f into main Apr 1, 2022
@maurolacy maurolacy deleted the 22-valset-tie-breaking-3 branch April 1, 2022 06:42
@maurolacy maurolacy mentioned this pull request Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

@ueco-jb ueco-jb Awaiting requested review from ueco-jb

@uint uint Awaiting requested review from uint

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees
No one assigned
Labels
breaking Breaking changes (API or State) breaking-api API breaking: Remove, Change (rename, change type), Add non-optional / non-default field breaking-state Storage breaking: Requires migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurolacy @hashedone