Valset tie breaking 2

[maurolacy]

Closes #22.

Alternative to #81: Uses an extra index for tie-breaking.

Publishing as Draft, as this is WIP / will be finished / merged later.

[hashedone]

You asked if it is not too much for this simple issue. To me - not. Actually you store only one additional u64 (height) per entry in state, so it is not heavy. Also it doesn't get complicated to me. The problem I see is that we have naming colision, and solving them by adding 2 is always bad idea, so maybe it still needs reconcideration of naming.

However - I see that this is not a change you introduced, there was it alredy in repo... I dislike it, but it seems to be another issue.

[maurolacy]

You asked if it is not too much for this simple issue. To me - not. Actually you store only one additional u64 (height) per entry in state, so it is not heavy. Also it doesn't get complicated to me. The problem I see is that we have naming colision, and solving them by adding 2 is always bad idea, so maybe it still needs reconcideration of naming.

However - I see that this is not a change you introduced, there was it alredy in repo... I dislike it, but it seems to be another issue.

Thanks for the feedback. I did that 2 naming in a hurry, will change it.

That's a minor thing. What I don't like about this is that it introduces a new function list_members_by_points_tie_breaking / query msg ListMembersByPointsTieBreaking. Perhaps removing that from tg4, and having it as a free-standing helper function / query?

[maurolacy]

Closing in favour of #118.