Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create simd/simcli commands + integration tests #5951

Closed
4 of 8 tasks
aaronc opened this issue Apr 7, 2020 · 17 comments
Closed
4 of 8 tasks

Create simd/simcli commands + integration tests #5951

aaronc opened this issue Apr 7, 2020 · 17 comments

Comments

@aaronc
Copy link
Member

aaronc commented Apr 7, 2020

Summary

Since gaia was moved into a separate repo, there haven't been cli commands in the SDK for simapp nor integration tests. Adding this to the SDK will help with testing in general, and particular help judge completeness of #5456.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jackzampolin
Copy link
Member

jackzampolin commented Apr 16, 2020

We should totally give simapp another name. I also know @alexanderbez would appreciate this. Possible options from a quick brainstorm on my side:

Personally I think carld and carlcli are pretty cool.

@aaronc
Copy link
Member Author

aaronc commented Apr 16, 2020

I know it will be a bit annoying, but maybe let's create a single comment per proposal and people can 👍 or 👎 the ones they like

@aaronc
Copy link
Member Author

aaronc commented Apr 16, 2020

cosmicd and cosmiccli

@aaronc
Copy link
Member Author

aaronc commented Apr 16, 2020

atomicd and atomiccli

@aaronc
Copy link
Member Author

aaronc commented Apr 16, 2020

fireflyd and fireflycli (Firefly)

@alexanderbez
Copy link
Contributor

https://namelix.com/app/?keywords=cosmos

@aaronc
Copy link
Member Author

aaronc commented Apr 16, 2020

Should we be changing the simapp/ folder too? atomicapp or atomic if we go with that?

@alexanderbez
Copy link
Contributor

Should we be changing the simapp/ folder too? atomicapp or atomic if we go with that?

Yes.

@sahith-narahari
Copy link
Contributor

I'll cross check if everything has been ported from gaia/cli-test and close this.

@aaronc @alexanderbez do we have a decision on what we want to rename the simapp to?

@alexanderbez
Copy link
Contributor

I have no strong preference here. @aaronc thoughts?

@alessio
Copy link
Contributor

alessio commented May 15, 2020

How about simula?

@aaronc
Copy link
Member Author

aaronc commented May 15, 2020

Seemed like people liked atomicd. But maybe we can come up with something better?

@tac0turtle
Copy link
Member

whats wrong with simd & simcli? It is the simplest & self-explanatory. They are only used for sims and testing so they aren't user-facing so naming shouldn't matter.

@alessio
Copy link
Contributor

alessio commented May 18, 2020

I agree with Marko on this. Naming should always try suggest what the program/library is for.

@aaronc
Copy link
Member Author

aaronc commented May 18, 2020

I agree, let's stick with simd/simcli for now. We have enough stuff in flux to get out for 0.39. And there are user facing naming decisions we do need to deal with

@clevinson
Copy link
Contributor

Being completed here: #6418

@aaronc
Copy link
Member Author

aaronc commented Jun 26, 2020

I think the correct status of this is done and improvements are continuing in #6423 (not #6418)

@aaronc aaronc closed this as completed Jun 26, 2020
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this issue May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants