Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf Encoding Migration #5456

Closed
wants to merge 46 commits into from
Closed

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Dec 30, 2019

This PR defines the basis of work for migration from Amino to full protobuf encoding. It includes:

  • Cleaning up/restructure of Makefile(s)
  • Addition of buf tooling
  • Migrating /types to protobuf
    • Coin
    • DecCoin
    • Implement CustomProtoType for Int and Uint (to allow gogo proto's customtype)
  • CI updates (TODO)

closes: #5444


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP T: State Machine Breaking State machine breaking changes (impacts consensus). C:Encoding labels Dec 30, 2019
types/decimal_test.go Show resolved Hide resolved
types/int.go Outdated Show resolved Hide resolved
@cosmos cosmos deleted a comment from codecov bot Jan 2, 2020
@cosmos cosmos deleted a comment from codecov bot Jan 2, 2020
@cosmos cosmos deleted a comment from codecov bot Jan 2, 2020
@alexanderbez alexanderbez deleted the bez/5444-proto-encoding branch January 16, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Encoding T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full Proto Encoding
3 participants