Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve getSDKVersion() to handle module replacements #17096

Merged
merged 4 commits into from
Jul 25, 2023
Merged

feat: Improve getSDKVersion() to handle module replacements #17096

merged 4 commits into from
Jul 25, 2023

Conversation

Ryz0nd
Copy link
Contributor

@Ryz0nd Ryz0nd commented Jul 23, 2023 •
edited
Loading

Description

Closes: #17122

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@Ryz0nd Ryz0nd changed the title feat: Improve getSDKVersion function to handle module replacements feat: Improve getSDKVersion() to handle module replacements Jul 23, 2023
@Ryz0nd Ryz0nd mentioned this pull request Jul 24, 2023
Closed
@Ryz0nd Ryz0nd marked this pull request as ready for review July 24, 2023 20:01
@Ryz0nd Ryz0nd requested a review from a team as a code owner July 24, 2023 20:01
@julienrbrt
Copy link
Member

Can we get a changelog under unreleased improvements?

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 24, 2023
@Ryz0nd
Copy link
Contributor Author

Ryz0nd commented Jul 25, 2023 •
edited
Loading

@julienrbrt Sure, I have updated it :)

julienrbrt
julienrbrt reviewed Jul 25, 2023
View reviewed changes
version/version.go Outdated Show resolved Hide resolved
@Ryz0nd @julienrbrt
fix: hide (devel) version
1a36ec5 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt julienrbrt added this pull request to the merge queue Jul 25, 2023
Merged via the queue into cosmos:main with commit b0acf60 Jul 25, 2023
44 of 46 checks passed
mergify bot pushed a commit that referenced this pull request Jul 25, 2023
@Ryz0nd @mergify
feat: Improve getSDKVersion() to handle module replacements (#17096)
42c9a36 
Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit b0acf60)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 25, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 25, 2023
@mergify @Ryz0nd @julienrbrt
feat: Improve getSDKVersion() to handle module replacements (backport
d234c6a 
#17096) (#17125)

Co-authored-by: devmosis <ryzond6728@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@Ryz0nd Ryz0nd deleted the handle-sdk-module-replacement branch January 16, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Improve getSDKVersion() to handle module replacements
2 participants
@Ryz0nd @julienrbrt