Proto encoding of gov and related modules #5493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jan 9, 2020
aaronc
force-pushed
the
aaronc/5444-proto-gov2
branch
from
c588458
to
36fbe5b
Compare
|
This pull request introduces 3 alerts when merging 347e041 into 2140244 - view on LGTM.com new alerts:
|
golangcibot
reviewed
Jan 11, 2020
aaronc
commented
Jan 17, 2020
aaronc
force-pushed
the
aaronc/5444-proto-gov2
branch
from
484ea2f
to
fe8fa35
Compare
Codecov Report
@@ Coverage Diff @@
## master #5493 +/- ##
===========================================
+ Coverage 35.46% 48.03% +12.56%
===========================================
Files 331 315 -16
Lines 32612 21599 -11013
===========================================
- Hits 11567 10375 -1192
+ Misses 19819 10425 -9394
+ Partials 1226 799 -427
|
aaronc
force-pushed
the
aaronc/5444-proto-gov2
branch
from
fe8fa35
to
372dff8
Compare
golangcibot
reviewed
Feb 17, 2020
| @@ -1,6 +1,7 @@ | |||
| package keeper | |||
|
|
|||
| import ( | |||
| proto "github.com/gogo/protobuf/types" | |||
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
Suggested change
| proto "github.com/gogo/protobuf/types" |
| @@ -45,7 +46,8 @@ func TestProposalQueues(t *testing.T) { | |||
|
|
|||
| activeIterator := keeper.ActiveProposalQueueIterator(ctx, proposal.VotingEndTime) | |||
| require.True(t, activeIterator.Valid()) | |||
| keeper.cdc.UnmarshalBinaryLengthPrefixed(activeIterator.Value(), &proposalID) | |||
| require.Equal(t, proposalID, proposal.ProposalID) | |||
| var proposalIdWrapper proto.UInt64Value | |||
There was a problem hiding this comment.
var proposalIdWrapper should be proposalIDWrapper (from golint)
aaronc
force-pushed
the
aaronc/5444-proto-gov2
branch
from
087b788
to
5faad87
Compare
…rything besides proposal)
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
aaronc
force-pushed
the
aaronc/5444-proto-gov2
branch
from
97aef12
to
8bd648e
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)