Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude protoc generated files from coverage report #5722

Closed

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 28, 2020


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@@ -165,6 +165,7 @@ jobs:
name: filter out DONTCOVER
command: |
excludelist="$(find ./ -type f -name '*.go' | xargs grep -l 'DONTCOVER')"
excludelist+="$(find ./ -name '*.pb.go')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be fixed in the codecov.yml file, this is a hack more or less

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea there is a weird bug with that. In this PR #5493 it seems to have done it correctly. maybe we wait to merge that to see what happens.

also in the next release of protogen-go-gocosmos it will default to create the test files for the autogenerated files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that makes total sense. Hence closing. Thanks!

@alessio alessio closed this Feb 28, 2020
@alessio alessio deleted the alessio/tweak-coverage-report-file-excludelist branch February 28, 2020 13:59
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #5722 into master will increase coverage by 19.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5722       +/-   ##
===========================================
+ Coverage   35.46%   54.53%   +19.07%     
===========================================
  Files         332      320       -12     
  Lines       32597    19044    -13553     
===========================================
- Hits        11559    10386     -1173     
+ Misses      19816     7839    -11977     
+ Partials     1222      819      -403
Impacted Files Coverage Δ
x/evidence/types/types.pb.go
x/staking/types/types.pb.go
x/slashing/types/types.pb.go
x/bank/types/types.pb.go
x/params/types/proposal/types.pb.go
x/distribution/types/types.pb.go
x/mint/types/types.pb.go
types/types.pb.go
x/upgrade/types/types.pb.go
x/auth/vesting/types/types.pb.go
... and 2 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants