-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude protoc generated files from coverage report #5722
Conversation
@@ -165,6 +165,7 @@ jobs: | |||
name: filter out DONTCOVER | |||
command: | | |||
excludelist="$(find ./ -type f -name '*.go' | xargs grep -l 'DONTCOVER')" | |||
excludelist+="$(find ./ -name '*.pb.go')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be fixed in the codecov.yml file, this is a hack more or less
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/cosmos/cosmos-sdk/blob/master/.codecov.yml#L49
For some reason these files are still reported as untested, e.g.:
https://codecov.io/gh/cosmos/cosmos-sdk/src/master/types/types.pb.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea there is a weird bug with that. In this PR #5493 it seems to have done it correctly. maybe we wait to merge that to see what happens.
also in the next release of protogen-go-gocosmos it will default to create the test files for the autogenerated files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that makes total sense. Hence closing. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #5722 +/- ##
===========================================
+ Coverage 35.46% 54.53% +19.07%
===========================================
Files 332 320 -12
Lines 32597 19044 -13553
===========================================
- Hits 11559 10386 -1173
+ Misses 19816 7839 -11977
+ Partials 1222 819 -403 |
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)