Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added es.lproj files #1504

Merged
merged 4 commits into from
Jul 30, 2023
Merged

Added es.lproj files #1504

merged 4 commits into from
Jul 30, 2023

Conversation

techagus
Copy link
Contributor

Since you don't handle me very well with git, I have replaced the Translate_to_Spanish branch with this call simply spanish with the only addition of the es.lproj folder with the Spanish translations without touching the rest of the content of the original project.

@techagus techagus requested a review from 1024jp as a code owner July 29, 2023 09:37
@1024jp 1024jp changed the title Añadidos los archivos de es.lproj Added es.lproj files Jul 30, 2023
@1024jp 1024jp self-assigned this Jul 30, 2023
@1024jp 1024jp added the localization tasks related to application localization label Jul 30, 2023
@1024jp 1024jp added this to the 4.6.0 milestone Jul 30, 2023
@1024jp
Copy link
Member

1024jp commented Jul 30, 2023

Great!! Thank you for your contribution.

Since you don't handle me very well with git, I have replaced the Translate_to_Spanish branch with this call simply spanish with the only addition of the es.lproj folder with the Spanish translations without touching the rest of the content of the original project.

Don't worry. I'll check the files and ask you if there are issues to be solved.

Before merging your PR, I'd like to confirm several things to you:

  1. Have you already read the localization guidance in CONTRIBUTING.md?
    If not yet, please check the description there.
  2. Could you be a continuous maintainer so that I can ask translation for future updates to you?
  3. I understand your Spanish is not Spanish (Latin America) but Spanish (Spain). Is it correct?

"RSI-QP-jZ1.title" = "¡Clarus dice moof!";

/* Class = "NSTextFieldCell"; title = "Found 4 strings in “Document.txt”."; ObjectID = "WJu-qO-b0n"; */
"WJu-qO-b0n.title" = "Se han encontrado 4 cadenas en "Document.txt".";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Typographer’s quotes (“”) instead of straight quotes in user interface.

"Hide indent guide lines" = "Ocultar línas guía de sangria";
"Show indent guide lines" = "Mostrar líneas guía de sangria";

"Keep on Top" = "Keep on Top";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation is missing.

"7iv-Gh-RFp.placeholderString" = "Auto";

/* Class = "NSTextFieldCell"; title = "Prefer tabs:"; ObjectID = "8zu-3V-Obg"; */
"8zu-3V-Obg.title" = "Preferencia de pestañas:";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose “Preferir pestañas:” is more simple and the expression Apple prefers.

@1024jp
Copy link
Member

1024jp commented Jul 30, 2023

Could you also translate the following strings for Localizable.stringsdict?
%lld is an integer.
(I know this file format is difficult to modify. So leaving the translations here as reply is enough. I'll update the file).

"%lld bytes" = "%lld bytes";  // zero
"%lld byte" = "%lld byte";  // singular
"%lld bytes" = "%lld bytes";  // plural

"%lld characters" = "%lld characters";  // zero
"%lld character" = "%lld character";  // singular
"%lld characters" = "%lld characters";  // plural

"%lld found" = "%lld found";
"%lld replaced" = "%lld replaced";

'Preferencia de pestañas' -> 'Preferir pestañas' in WindowPane.strings
'Keep on top' -> 'Mantener en primer plano' in Localizable.strings
@techagus
Copy link
Contributor Author

Hello
In the last revision I have included the suggested adjustments. For translate Localizable.stringsdict I have taken as a model the one made in French

As for the questions, the answer is 'yes' to all.

One question, if I decide to also translate the help into Spanish, what would be the steps to follow.

Thanks for everything.

@1024jp 1024jp merged commit 0cab85b into coteditor:main Jul 30, 2023
1 check failed
@techagus techagus deleted the spanish branch July 30, 2023 13:03
1024jp added a commit that referenced this pull request Jul 30, 2023
1024jp added a commit that referenced this pull request Jul 30, 2023
@1024jp
Copy link
Member

1024jp commented Aug 15, 2023

Sorry for my late reply.
Thank you all for your contribution and kind agree with my questions.
The Spanish localization will be shipped with CotEditor 4.6.0 that will be released this autumn when macOS 14 Sonoma is released.
Before the release, I'll ask you additional translation for the strings added in this version.

One question, if I decide to also translate the help into Spanish, what would be the steps to follow.

I appreciate this also. However, CotEditor currently doesn't offer localizations of the help contents to leave room for free and drastic updates whenever I like.

@techagus
Copy link
Contributor Author

Hello.
No problem, when you have the strings to translate, send them to me, and I'll give you the translations. The translation of the help into Spanish is a few days away from finishing it, if you want I'll send it to you with a pull request or I can use it personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization tasks related to application localization
Development

Successfully merging this pull request may close these issues.

2 participants