Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): exclude dev patches of npm releases #304

Merged
merged 4 commits into from
Jul 5, 2021
Merged

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Jun 28, 2021

Proposed changes

I edited the file section of the package.json of @coveo/cli to exclude all .dev.patch from the npm published package.
It's OK to exclude those because they only affect devDependencies and the devDependencies are not installed when running npm i -G @coveo/cli or npx @coveo/cli.

Testing

  • ❌ Unit Tests: Not Applicable
  • ❌ Functional Tests: Not Applicable
  • Manual Tests:
    • npm pack and analyzed the generated tarball, as recommended in the NPM documentation

image

  • Did a release on baguette-cli with the change and ran npm install -g baguette-cli@latest from a clean machine to ensure the problem was solved
    image

Fixes:
CDX-335
#291

@louis-bompart louis-bompart merged commit 0a2b164 into master Jul 5, 2021
@louis-bompart louis-bompart deleted the CDX-335 branch July 29, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants