Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install binary to a less permissive location by default #105

Merged
merged 3 commits into from
Dec 30, 2023

Conversation

egladman
Copy link
Contributor

@egladman egladman commented Dec 6, 2023

I ran into a few issues when trying to run this action on self-hosted runners.

The following changes were made and are backwards compatible:

  • gracefully stop containers
    • Previously docker stop would still be executed even if there weren't any containers present
  • install the dagger binary to a less permissive path
    • previously the action would fail to run since /usr/local wasn't writable by default
    • installs the binary to a temporary location that's accessible to the entire job/steps, then add that location to the GITHUB_PATH.

Signed-off-by: Eli Gladman <8713153+egladman@users.noreply.github.com>
…ners

Signed-off-by: Eli Gladman <8713153+egladman@users.noreply.github.com>
@egladman
Copy link
Contributor Author

egladman commented Dec 6, 2023

This PR goes about it in a different way, however it addresses #77

Signed-off-by: Eli Gladman <8713153+egladman@users.noreply.github.com>
@jpadams
Copy link
Contributor

jpadams commented Dec 15, 2023

@egladman Thank you for the PR! Reviewing it now!

@jpadams jpadams self-requested a review December 30, 2023 06:36
Copy link
Contributor

@jpadams jpadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpadams jpadams merged commit 5994e78 into dagger:main Dec 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants