don't fail if the engine is not running #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
|
Fixes #106 |
jpadams
reviewed
Dec 30, 2023
There was a problem hiding this comment.
Thanks, @marcosnils !!
I accepted a prior PR that also implements this.
https://github.com/dagger/dagger-for-github/pull/105/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R61-R63
Yours is super elegant, but I also added a guard in another PR so we only attempt to run the docker stop if there are some dagger-engine container(s) present. So I'm thinking we can close your PR for now since it's fixed and tested above.
|
Hey Jeremy! IIUC #105 doesn't seem to have the same effect of what I'm fixing here. What am I missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcos Lilljedahl marcosnils@gmail.com