Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show thread ids and names #12

Merged
merged 3 commits into from
Aug 8, 2020
Merged

Conversation

oli-obk
Copy link
Collaborator

@oli-obk oli-obk commented Aug 5, 2020

based on #11

Screenshot from 2020-08-05 14-53-52

@davidbarsky
Copy link
Owner

Few notes:

  • What do you mean by "I can't figure out how to make this work reasonably on the first event/span emitted"?
  • Is the screenshot right? I'm sure I'm seeing the thread names/IDs...
  • Can you rebase since I merged Allow rendering the event/span target #11?

@oli-obk
Copy link
Collaborator Author

oli-obk commented Aug 6, 2020

* What do you mean by "I can't figure out how to make this work reasonably on the first event/span emitted"?

If you look at the first line, there's no thread id/name preprended.... and I just realized this can't work the way I implemented it 🤦 We'd get the thread id and name of the span/event before the line being emitted. Ah no, I misunderstood how things worked, it's all superb

@oli-obk
Copy link
Collaborator Author

oli-obk commented Aug 7, 2020

Nevermind, I figured it out ^^ I just overlooked one edge case

@davidbarsky
Copy link
Owner

Nice! Thanks for this. One thing that can be done a followup: since I prefer to use narrow fonts (Pragmata Pro!), it'd be nice to give a bit of spacing between the thread name and ID and the target:
Screen Shot 2020-08-08 at 1 42 12 PM

@davidbarsky davidbarsky merged commit 6a8c7fd into davidbarsky:master Aug 8, 2020
@davidbarsky davidbarsky mentioned this pull request Aug 8, 2020
@oli-obk
Copy link
Collaborator Author

oli-obk commented Aug 8, 2020

it'd be nice to give a bit of spacing between the thread name and ID and the target:

Do you mean just for the cases where there's no indent at all or just put a space after the thread name in general?

@oli-obk oli-obk deleted the threads branch August 8, 2020 23:25
oli-obk added a commit to oli-obk/tracing-tree that referenced this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants