Wraparound #15
Merged
Wraparound #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks good! I suspect that fancier, column-based highlighting-on-selection would require something significantly fancier, and if this helps in Miri, we'll worry about that later. Can you rebase since I just merged #12? After you rebase and merge, I'll do a release of
|
I can't really picture it, do you have an artificial example of how that would look? |
|
Not really! I was spitballing along the lines of "huh, getting ncurses or some JavaScript to render this would be neat", but that's a much bigger yak shave than I can reasonably suggest now. Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14