Add ability to set function name on php_function macro #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptondereau
approved these changes
Sep 19, 2022
|
@joehoyle: You might want to rebase your changes on top of the current |
|
@striezel @ptondereau ok can do-- I wanted to check if anyone have merge capabilities though? As I wasn't sure how abandoned the project is right now. Are either of you happy / able to merge things? |
|
For the moment, only @TobiasBengtsson have the merge right. But for us, we just review the PR. |
This is much the same as `php_class(name="ABC")`
joehoyle
force-pushed
the
add-name-function-macro
branch
from
561f6ae
to
18ede97
Compare
|
@TobiasBengtsson ok this should be good now. |
|
Thanks! It would be nice to have more maintainers in fact, since I don't have that much time. See #140 and email David if you're interested @striezel @ptondereau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much the same as
php_class(name="ABC")