Accumulated minor nits and fixes. #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Sep 20, 2023
Create the shutdown context earlier so process begins handling shutdown signals earlier. Specifically, the context should be created before creating any resources which need a graceful shutdown such as the database. This is important because without explicit signal handling the process will terminate immediately upon receiving a signal without running deferred tasks.
The more verbose name was helpful in the past when some code was handling more than one waitgroup, however that is no longer the case due to refactoring so reverting to the more concise name makes sense.
When invoked with -v, curl actually outputs a message to indicate that this extra param is unnecessary: "Note: Unnecessary use of -X or --request, GET is already inferred."
Getting an agenda ID dynamically so that this doesnt need to be manually updated for future vote versions.
The overlay setting for overflow has been deprecated for quite some time, and these days doesn't work on most browsers.
The error returned by dcrd.Client() is already very descriptive and does not need extra context.
A good comment explains what a function does, not when it is called.
jholdstock
force-pushed
the
early-context
branch
from
7c4e8df
to
be780a2
Compare
|
Rebased and added one extra commit. Good to go. |
davecgh
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of small things I've noticed during testing/reviewing. Nothing big enough to warrant its own PR so I've accumulated them here.