Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accumulated minor nits and fixes. #446

Merged
merged 8 commits into from
Sep 26, 2023
Merged

Accumulated minor nits and fixes. #446

merged 8 commits into from
Sep 26, 2023

Commits on Sep 26, 2023

  1. vspd: Create shutdown context earlier. 

    Create the shutdown context earlier so process begins handling shutdown
signals earlier. Specifically, the context should be created before
creating any resources which need a graceful shutdown such as the
database. This is important because without explicit signal handling the
process will terminate immediately upon receiving a signal without
running deferred tasks.
    @jholdstock
    jholdstock committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    a076bd3 View commit details
    Browse the repository at this point in the history

  2. multi: Rename shutdownWg to wg. 

    The more verbose name was helpful in the past when some code was
handling more than one waitgroup, however that is no longer the case due
to refactoring so reverting to the more concise name makes sense.
    @jholdstock
    jholdstock committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    3debda7 View commit details
    Browse the repository at this point in the history

  3. docs: Simplify curl example for status endpoint. 

    When invoked with -v, curl actually outputs a message to indicate that
this extra param is unnecessary:

"Note: Unnecessary use of -X or --request, GET is already inferred."
    @jholdstock
    jholdstock committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8a37687 View commit details
    Browse the repository at this point in the history

  4. v3tool: Remove hard-coded agenda ID. 

    Getting an agenda ID dynamically so that this doesnt need to be manually
updated for future vote versions.
    @jholdstock
    jholdstock committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    504a0b2 View commit details
    Browse the repository at this point in the history

  5. webapi: Remove deprecated css. 

    The overlay setting for overflow has been deprecated for quite some
time, and these days doesn't work on most browsers.
    @jholdstock
    jholdstock committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    5c366f4 View commit details
    Browse the repository at this point in the history

  6. webapi: Don't add extra context to dcrd errors. 

    The error returned by dcrd.Client() is already very descriptive and does
not need extra context.
    @jholdstock
    jholdstock committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d2a8205 View commit details
    Browse the repository at this point in the history

  7. multi: Use const where possible.

    @jholdstock
    jholdstock committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0f10542 View commit details
    Browse the repository at this point in the history

  8. vspd: Improve comment for update func. 

    A good comment explains what a function does, not when it is called.
    @jholdstock
    jholdstock committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    be780a2 View commit details
    Browse the repository at this point in the history