Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @deltachat/stdio-rpc-server and deltachat/jsonrpc-client to 1.42.1 and minor npm dependency updates #4054

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

nicodh
Copy link
Contributor

@nicodh nicodh commented Jul 30, 2024

@nicodh
Copy link
Contributor Author

nicodh commented Jul 30, 2024

@Simon-Laux not sure what we should add here into CHANGELOG

@nicodh nicodh requested a review from Simon-Laux July 30, 2024 06:00
@nicodh
Copy link
Contributor Author

nicodh commented Jul 30, 2024

TODO: check wether we should handle the new property "quotedText" see Just text quote

@nicodh nicodh mentioned this pull request Jul 30, 2024
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json update and changelog updates are missing. for change log just look to previous versions and copy the line about the core update, if it could be interesting for users also mention some of the changes of core below (in a nested list item.

@Simon-Laux
Copy link
Member

TODO: check wether we should handle the new property "quotedText" see deltachat/deltachat-core-rust#5695

I think we just need to explicitly set it to null because of deltachat/yerpc#10

@link2xt
Copy link
Collaborator

link2xt commented Jul 30, 2024

1.42.0 does not contain the fix yet.

@link2xt
Copy link
Collaborator

link2xt commented Jul 30, 2024

I tagged core 1.142.1 that has "Explicitly close the database on account removal" fix. npm packages should be published automatically soon.

@link2xt link2xt changed the title Update @deltachat/stdio-rpc-server and deltachat/jsonrpc-client to 1.42.0 Update @deltachat/stdio-rpc-server and deltachat/jsonrpc-client to 1.42.1 Jul 31, 2024
@nicodh nicodh changed the title Update @deltachat/stdio-rpc-server and deltachat/jsonrpc-client to 1.42.1 Update @deltachat/stdio-rpc-server and deltachat/jsonrpc-client to 1.42.1 and minor npm dependency updates Aug 1, 2024
@Simon-Laux Simon-Laux self-requested a review August 1, 2024 21:55
@nicodh nicodh merged commit 1aa842e into main Aug 2, 2024
7 checks passed
@nicodh nicodh deleted the core-update-fix-3959 branch August 2, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants