Fix order of css rules #4055
Merged
Fix order of css rules #4055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since v1.77.7 the behaviour of compiling css from nested rules changed: https://sass-lang.com/documentation/breaking-changes/mixed-decls/ To avoid warnings and keep the old structure of the compiled css all properties should occur before nested rules
nicodh
force-pushed
the
fix-sass-rule-order
branch
from
832d3e1
to
b3e8fed
Compare
|
So, is this just a refactor? Have you seen if something is bugged without this, but with the upgrade of SASS? |
WofWca
reviewed
Jul 30, 2024
src/renderer/components/screens/WelcomeScreen/OnboardingScreen.tsx
Outdated
Show resolved
Hide resolved
|
There were warnings when building. In future the generated css will look different then before. With these changes the generated css should stay the same, at least according to the documentation |
WofWca
approved these changes
Jul 30, 2024
WofWca
approved these changes
Jul 30, 2024
Simon-Laux
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since v1.77.7 the behaviour of compiling css from nested rules changed: https://sass-lang.com/documentation/breaking-changes/mixed-decls/
To avoid warnings and keep the old structure of the compiled css all properties should occur before nested rules
Follow up of #4054