Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add check for NNZ in COOToCSR #7459

Merged
merged 13 commits into from
Jun 17, 2024
Merged

Conversation

Skeleton003
Copy link
Collaborator

Description

Add check for the number of non-zero elements (NNZ) during the conversion from COOMatrix to CSRMatrix within the spmat_op_impl_coo.cc file.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

Commit ID: 57b1572

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

Copy link
Collaborator

@Rhett-Ying Rhett-Ying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add dedicated testcase

@Skeleton003
Copy link
Collaborator Author

pls add dedicated testcase

I'm afraid it's a little bit difficult because we need to construct a COO with more than 2B NNZ for a testcase.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

Commit ID: 73dc413

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

Commit ID: 716acae329f74e95ba2294d36bcb8e123fde0c3c

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

Commit ID: afaa2abccb45010ec2f166a87b06f773ee06c1c0

Build ID: 4

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

Commit ID: 86f8846

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

Commit ID: 86f8846

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 14, 2024

Commit ID: e3b1fad64c3d4151268fb6eeddfe69fd2866619d

Build ID: 7

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@Rhett-Ying
Copy link
Collaborator

The CI failed due to glitch in distributed testcases. It's ok to ignore such failures.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 17, 2024

Commit ID: 382eda5747196694157684f9d178632748c7527c

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit cbad2f0 into dmlc:master Jun 17, 2024
2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants