Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add check for NNZ in COOToCSR #7459

Merged
merged 13 commits into from
Jun 17, 2024
Merged

[Feature] Add check for NNZ in COOToCSR #7459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
57b1572
1
Skeleton003 Jun 13, 2024
73dc413
lint
Skeleton003 Jun 13, 2024
fbb319d
rm
Skeleton003 Jun 13, 2024
1b0b40c
use macro
Skeleton003 Jun 13, 2024
7c1fd12
add check in cuda file
Skeleton003 Jun 13, 2024
e0ea0f9
1
Skeleton003 Jun 13, 2024
fae0f4e
lint
Skeleton003 Jun 13, 2024
bb9d2f1
rm
Skeleton003 Jun 13, 2024
14ac2ef
use macro
Skeleton003 Jun 13, 2024
86f8846
add check in cuda file
Skeleton003 Jun 13, 2024
af54b6e
Merge branch 'checknnz' of github.com:Skeleton003/dgl into checknnz
Skeleton003 Jun 13, 2024
55d82c4
constexpr
Skeleton003 Jun 14, 2024
f7388fe
remove if
Skeleton003 Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/array/cpu/spmat_op_impl_coo.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,7 @@ inline COOToCSRAlg WhichCOOToCSR(const COOMatrix &coo) {

template <DGLDeviceType XPU, typename IdType>
CSRMatrix COOToCSR(COOMatrix coo) {
CHECK_NO_OVERFLOW(coo.row->dtype, coo.row->shape[0]);
switch (WhichCOOToCSR<IdType>(coo)) {
case COOToCSRAlg::sorted:
return SortedCOOToCSR<IdType>(coo);
Expand Down
1 change: 1 addition & 0 deletions src/array/cuda/coo2csr.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ CSRMatrix COOToCSR<kDGLCUDA, int32_t>(COOMatrix coo) {
}

const int64_t nnz = coo.row->shape[0];
CHECK_NO_OVERFLOW(coo.row->dtype, nnz);
// TODO(minjie): Many of our current implementation assumes that CSR must have
// a data array. This is a temporary workaround. Remove this after:
// - The old immutable graph implementation is deprecated.
Expand Down
Loading