Prevents entering a blank group name #3169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We switched pipelines with v9.4.0, and this just updates the badge to the correct url so show successful build status on the homepage of the project.
Now that we have a security policy in GitHub, this is handled for us
* Update GlobalResources.resx Copyright in mails sent to friends, friend requesrts etc was 2013 hard coded. No [portal] * Add year token to emails
- This is to ensure AlternativeView encoding is always consistent with bodyEncoding and not relying on the body text - Extract the code to AddAlternateView method to allow UTs
…Mail-SendMail-alternate-view Missing encoding in email alternate view
Added branching explanation to PR documentation
* Updates bug reports issue template Updates the bug report template to only show the supported releases and direct users to forums for older ones. * Update feature-request.md Feature requests should not be version depended since they would be a new feature, they would just not exist yet. * Update help-and-other-questions.md * Update request-for-comments.md
Update development with fixes from v9.4.0-rc
* Fix error running unit tests (#2940) When running tests, the following error occurs: VSTest: Could not locate executable. cake-build/cake#1522 (comment) indicates that there's an issue using VS 2019, and presents a workaround to find the correct path * DNN-31366 - Deleted page can still be selected as parent page (#2925) * DNN-31366 - TabController HasChildren returns false if all children are deleted * Simplify HasChildren condition
* Cleanup of Obsolete items from the log4net project * Miseed one in Log4Net * Removed obsolete methods from DotNetNuke.Web * Changes necessary for the removeal of Obsolete items from the DotNetNuke.Library project. * Removed obsolete items from the Modules/DDRMenu project * Removal of obsolete items from Website project. Bumped one item to 11.x for further review * Corrected Unit Test Data File Removed one of the properties from the list as it was removed
* Fix error running unit tests (#2940) When running tests, the following error occurs: VSTest: Could not locate executable. cake-build/cake#1522 (comment) indicates that there's an issue using VS 2019, and presents a workaround to find the correct path * DNN-31366 - Deleted page can still be selected as parent page (#2925) * DNN-31366 - TabController HasChildren returns false if all children are deleted * Simplify HasChildren condition * deleting_themes_from_Extensions_doesnt_remove_it_from_themes (#2950) * Returns the working types if some fail (#2953)
* Updates issue templates as per 9.4.0 release * Update help-and-other-questions.md * Update request-for-comments.md
Merged the admin experience into development
* Updated Documentation * Corrected typo Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com>
* Removed spacing so documentation link renders correctly * Added link to security vulnerability process * Updated process to policy and fixed broken link
…lidate RoleGroup Name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Steps
Expected Result: Error message should be displayed --> The argument 'Name' cannot be null or empty. Parameter name: Name
Fixes #2927
Summary
Added validation method to determine whether the argValue is null, empty, or has whitespace only. Also updated the RoleGroup Name validation to reference the new validation method.