Update development with fixes from v9.4.0-rc #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix for Custom Authentication Providers * Fix typo
* switched direct reference to PetaPoco with Nuget package * fixed issue preventing our custom mapper from registering Fixes #2817
…Removal exist before pulling them from the datareader.
Filename illegal characters check
…tor (#2877) * Fixes issue with checkboxes in Google Analytics Connector * Update DNN Platform/Connectors/GoogleAnalytics/GoogleAnalyticsConnector.cs Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Update DNN Platform/Connectors/GoogleAnalytics/GoogleAnalyticsConnector.cs Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Update DNN Platform/Connectors/GoogleAnalytics/GoogleAnalyticsConnector.cs Yep, missed that one Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Update DNN Platform/Connectors/GoogleAnalytics/GoogleAnalyticsConnector.cs yeah, it carries meaning Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Update DNN Platform/Connectors/GoogleAnalytics/GoogleAnalyticsConnector.cs This is a better performance right? Just curious because I find the original more readable, but approving the change Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com> * Corrected HandleCustomBoolean takes a string input * Update DNN Platform/Connectors/GoogleAnalytics/GoogleAnalyticsConnector.cs Co-Authored-By: Brian Dukes <bdukes@engagesoftware.com>
* Removes duplication of license files * Removes duplication of license files
|
@ohine Should this be merged? |
valadas
approved these changes
Aug 10, 2019
|
@mitchelsellers the build failed because of a failure in the call to the Azure API, I think that's what @ohine was talking about being in the way of generating a new RC… |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Makes temp dir local * Ignores build results folders from git * Backup manifests and restore after build * Added Website/Templates to gitignore * Fixed more references to c:\temp * Build documentation * Fixed wrong tempdir path * Fixed wrong path for AE packaging * Updated build instructions * Deleted Cake Folder * Recreated Cake folder with Uppercase * Adjusted to use Cake instead of cake folder * Trying to remove Cake.LongPath Module * Bumped cake addins versions to latest working versions * pins cake version and commits it * Revert "Trying to remove Cake.LongPath Module" This reverts commit 3ed4eee. * Pins Cake to v0.26.0 to prevent build warnings
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bdukes
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The referenced changes have already been approved. Since this is a release management task we are self approving the merge without any reviews.