Implemented a new optional file manager called Resource Manager #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/resource manager
Ensure yarn runs when module is built
Fix resource manager to use the revised upload file handler in the core
* Standardization of File Headers * Standardized license file * Improved generic enum description value * Code standardization & cleanup * Updated to remove [AllowAnonymous] from API calls to fall back to Module Permissions
* First try at merging the build * Trying to fix lerna build * Should fix eslint errors * Fixes some dependency versions * Fix store and downgrade react-dropzone as it required react 16.8 * Fixing references * Fixes missing references and updates some * Fixes whitespace eslint warnings * Fixes css issue with visibility of upload button Co-authored-by: Peter Donker <peter@bring2mind.net>
Co-authored-by: Daniel Valadas <info@danielvaladas.com>
Further fixes to RM
That prevented the buid from running
Fixes 2 wrong merged conflicts resolutions
Add better wildcard file search support
Meged latest changes from development into the resource manager feature branch
#4007) * First code push * Adds own implementation of PB DnnSf * Some more fixes Co-authored-by: Peter Donker <peter@bring2mind.net>
The frontend build of the new resource-manager had many warnings which this PR resolves. (whitespace and unused vars and method parameters).
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Enabled StyleCop & Fixed All Build Errors/Warnings
Updated feature/resource-manager with latest changes from develop
Rebase feature/resource-manager with latest changes on develop
Implemented file/folder move in resource manager.
Rebases feature/resource-manager with latest changes from develop
mitchelsellers
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
I have reviewed this PR, and the final solution, on the feature branch which was just brought inline from the develop branch.
I've reviewed the contributions from a security perspective and will continue to review during the 9.7.0 RC. Given the time spent, and individuals involved I am requesting an independent review from either @bdukes or @mtrutledge to be the final merging/approving vote on this inclusion. As such, I'm adding the on-hold label to ensure that we don't accidentally merge.
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 32.2%, saving 358.12 KB.
1249 images did not require optimisation. |
david-poindexter
approved these changes
Oct 6, 2020
yarn.lock is what will be used
|
I pushed some small changes, doing a little testing still. |
bdukes
approved these changes
Oct 6, 2020
|
@mitchelsellers are we good to remove On Hold? |
|
Yes we are! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new file manager allows us to no longer have any code that relies on Telerik libraries.
This does not replace the current file manager automatically but allows those who want to replace it. Doing so with this release means (providing no other 3rd party modules use Telerik) that the Telerik libraries and bindings can be completely removed.