Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --with-system-ffi configure option is redundant on Linux for Python 3.7+ #715

Closed
edmorley opened this issue Apr 9, 2022 · 0 comments · Fixed by #716
Closed

The --with-system-ffi configure option is redundant on Linux for Python 3.7+ #715

edmorley opened this issue Apr 9, 2022 · 0 comments · Fixed by #716

Comments

@edmorley
Copy link
Contributor

edmorley commented Apr 9, 2022

Hi!

The Dockerfiles for Linux in this repository currently pass --with-system-ffi to configure:

--with-system-ffi \

This option was added back in #205 / #358.

However, as of Python 3.7+ using the system ffi library is the default for Linux:
https://bugs.python.org/issue27979
python/cpython@f40d4dd#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810

As such, builds are currently emitting this warning during configure:

checking for --with-system-ffi... yes
configure: WARNING: --with(out)-system-ffi is ignored on this platform

Examples in CI on this repo:

Given that this repo no longer supports Python versions older than Python 3.7, it seems this option can now be dropped?

edmorley added a commit to edmorley/python that referenced this issue Apr 9, 2022
Since as of Python 3.7+ using system `ffi` is now mandatory (and so the default)
on Linux:
https://bugs.python.org/issue27979
python/cpython@f40d4dd

Removing the option resolves this configure warning:

```
checking for --with-system-ffi... yes
configure: WARNING: --with(out)-system-ffi is ignored on this platform
```

Closes docker-library#715.
cpressland added a commit to binkhq/python that referenced this issue Oct 2, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant