Fix _ctypes test failure on Alpine and build failure on Debian on ppc64le #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix works for arm64v8 too! (python 3.3, 3.4, 3.5, and 3.6) |
tianon
reviewed
Jun 16, 2017
3.3/Dockerfile
Outdated
| @@ -46,6 +48,8 @@ RUN set -ex \ | |||
| --build="$gnuArch" \ | |||
| --enable-loadable-sqlite-extensions \ | |||
| --enable-shared \ | |||
| --with-system-ffi \ | |||
| --with-system-expat \ | |||
There was a problem hiding this comment.
I apparently sorted everything else but that 😞
|
All green! |
tianon
approved these changes
Jun 16, 2017
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jun 16, 2017
- `php`: multiarch (docker-library/php#454) - `python`: multiarch (docker-library/python#205, docker-library/python#206) - `redmine`: passenger 5.1.5 - `wordpress`: multiarch (docker-library/wordpress#223) -- slightly cheated by pointing it at the `library/php` file contents from this PR
JayH5
added a commit
to praekeltfoundation/docker-alpine-python
that referenced
this pull request
Jun 19, 2017
tao12345666333
pushed a commit
to tao12345666333/python
that referenced
this pull request
Jun 28, 2018
Fix _ctypes test failure on Alpine and build failure on Debian on ppc64le
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces/closes #190.
@elbaschid, sorry to replace your PR, I was working on multi-arch images and found out that this fixes the build for ppc64le (https://bugs.python.org/issue22157), so I applied it to all the versions of python 3.
This might fix the build failure on arm64v8, but I haven't tested it there yet.