Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve loaders correctly #333

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Oct 10, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Ensure that loaders are resolved correctly.

Resolves #331

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #333 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   48.39%   48.39%           
=======================================
  Files          10       10           
  Lines         686      686           
  Branches      195      195           
=======================================
  Hits          332      332           
  Misses        354      354
Impacted Files Coverage Δ
src/base.config.ts 19.65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b8a2b...2e3e5d1. Read the comment docs.

@agubler agubler merged commit 2007b2f into dojo:master Oct 10, 2019
agubler added a commit to agubler/cli-build-app that referenced this pull request Oct 10, 2019
@agubler agubler mentioned this pull request Oct 10, 2019
3 tasks
agubler added a commit that referenced this pull request Oct 10, 2019
* resolve loaders correctly (#333)

* use transpile only with tsnode (#334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure loader resolution defaults to the scope of this package
2 participants